Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow --home to propagate to init command #10104

Merged
merged 8 commits into from
Sep 9, 2021
Merged

fix: Allow --home to propagate to init command #10104

merged 8 commits into from
Sep 9, 2021

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Sep 9, 2021 •
edited
Loading

Description

closes: #10092

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@orijbot
Copy link

orijbot commented Sep 9, 2021

Visit https://dashboard.github.orijtech.com?back=0&pr=10104&remote=false&repo=cosmos%2Fcosmos-sdk to see benchmark details.

@github-actions github-actions bot added C:CLI C:x/genutil genutil module issues labels Sep 9, 2021
@fedekunze fedekunze added the A:automerge Automatically merge PR once all prerequisites pass. label Sep 9, 2021
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #10104 (c401c60) into master (1820647) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10104      +/-   ##
==========================================
+ Coverage   63.58%   63.60%   +0.01%     
==========================================
  Files         572      572              
  Lines       53586    53588       +2     
==========================================
+ Hits        34075    34085      +10     
+ Misses      17566    17557       -9     
- Partials     1945     1946       +1
Impacted Files Coverage Δ
client/cmd.go 58.28% <ø> (ø)
x/genutil/client/cli/init.go 67.85% <100.00%> (+6.94%) ⬆️
crypto/keys/internal/ecdsa/privkey.go 84.21% <0.00%> (+1.75%) ⬆️

@alexanderbez alexanderbez merged commit 148451b into master Sep 9, 2021
@alexanderbez alexanderbez deleted the bez/10092-fix-init-home-flag branch September 9, 2021 20:22
@askolesov askolesov mentioned this pull request Sep 15, 2021
Closed
@alexanderbez
Copy link
Contributor Author

@Mergifyio backport release/v0.44.x

mergify bot pushed a commit that referenced this pull request Sep 15, 2021
@alexanderbez
fix: Allow --home to propagate to init command (#10104)
096675a 
(cherry picked from commit 148451b)

# Conflicts:
#	CHANGELOG.md
#	x/genutil/client/cli/init.go
#	x/genutil/client/cli/init_test.go
@mergify mergify bot mentioned this pull request Sep 15, 2021
Merged
@mergify
Copy link
Contributor

mergify bot commented Sep 15, 2021

Command backport release/v0.44.x: success

Backports have been created

alexanderbez pushed a commit that referenced this pull request Sep 15, 2021
@mergify
fix: Allow --home to propagate to init command (backport #10104) (#10158
6cfa58f 
)
evan-forbes pushed a commit to evan-forbes/cosmos-sdk that referenced this pull request Oct 12, 2021
@mergify
fix: Allow --home to propagate to init command (backport cosmos#10104) (
815c19b 
cosmos#10158)
evan-forbes pushed a commit to evan-forbes/cosmos-sdk that referenced this pull request Nov 1, 2021
@mergify
fix: Allow --home to propagate to init command (backport cosmos#10104) (
d0c32f3 
cosmos#10158)
@fedekunze fedekunze mentioned this pull request Nov 14, 2021
Closed
19 tasks
Eengineer1 pushed a commit to cheqd/cosmos-sdk that referenced this pull request Aug 26, 2022
@mergify @Eengineer1
fix: Allow --home to propagate to init command (backport cosmos#10104) (
3919443 
cosmos#10158)
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
@mergify @JeancarloBarrios
fix: Allow --home to propagate to init command (backport cosmos#10104) (
c44be9e 
cosmos#10158)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atheeshp atheeshp atheeshp approved these changes

@fedekunze fedekunze fedekunze approved these changes

@aaronc aaronc Awaiting requested review from aaronc

Assignees

@blushi blushi

@atheeshp atheeshp

Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:x/genutil genutil module issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Init command doesn't respect --home flag
5 participants
@alexanderbez @orijbot @fedekunze @atheeshp @blushi